Commit Graph

2 Commits (main)

Author SHA1 Message Date
_ 68461866d8 🐛 bug: popping is gone
It was a combination of two bugs:

1. For some reason, libswresample sometimes returns more data than you need.
Like, it'll return X samples but _more than_ 8X bytes, for f32 stereo.

2. I wasn't supposed to be calling `flush`. I should have been calling
`run` with a dummy frame. This isn't intuitive to me, and it required
me to construct a dummy frame and keep it around in my code. I think
this is pretty inelegant. And looking at the ffmpeg code, I think it's
a flaw in the API design of the `ffmpeg_next` crate. I may ask them
about it in the future.
2021-11-13 11:23:10 -06:00
_ 3f5be609ea it's good and seamless except for that dang popping! 2021-11-13 01:11:11 +00:00