From 429d1cc957c67adb5aa5c22dca82c82b0496d611 Mon Sep 17 00:00:00 2001
From: _ <>
Date: Sun, 11 Jul 2021 10:56:40 +0000
Subject: [PATCH] :bug: bug: don't leak request IDs in the audit log

---
 crates/ptth_relay/src/lib.rs         | 1 -
 crates/ptth_relay/src/relay_state.rs | 1 -
 todo.md                              | 1 -
 3 files changed, 3 deletions(-)

diff --git a/crates/ptth_relay/src/lib.rs b/crates/ptth_relay/src/lib.rs
index 495a6a1..0c69229 100644
--- a/crates/ptth_relay/src/lib.rs
+++ b/crates/ptth_relay/src/lib.rs
@@ -138,7 +138,6 @@ async fn handle_http_request (
 	
 	state.audit_log.push (AuditEvent::new (AuditData::WebClientGet {
 		user,
-		req_id: req_id.clone (),
 		server_name: server_name.to_string (),
 		uri,
 	})).await;
diff --git a/crates/ptth_relay/src/relay_state.rs b/crates/ptth_relay/src/relay_state.rs
index 8bd0870..c08cfbf 100644
--- a/crates/ptth_relay/src/relay_state.rs
+++ b/crates/ptth_relay/src/relay_state.rs
@@ -123,7 +123,6 @@ pub enum AuditData {
 	RelayStart,
 	WebClientGet {
 		user: Option <String>,
-		req_id: String,
 		server_name: String,
 		uri: String,
 	},
diff --git a/todo.md b/todo.md
index 486f622..e793417 100644
--- a/todo.md
+++ b/todo.md
@@ -1,7 +1,6 @@
 Interesting issues will get a unique ID with
 `dd if=/dev/urandom bs=5 count=1 | base32`
 
-- Don't leak request ID in audit log
 - Fix long-running downloads restarting in the middle
 - [DMX6CO4G](issues/2021-01Jan/status-DMX6CO4G.md) fire-and-forget logs / key-value status data
 - ptth_tail